Fix/keyboard tracking view ios #1849

Inbal-Tish · 2022-02-15T09:09:04Z

Description

KeyboardTrackingView - iOS - fix View's translation when nested in a TabBarController.
Verified on iPhone 12 iOS 14.4 and iPhone 8 iOS 13.7

KeyboardTrackingView - iOS - fix View's translation when nested in a TabBarController.

ethanshar · 2022-02-15T10:28:58Z

@Inbal-Tish
Couple of things regarding this fix.

It's a fix in our native code, that means we need to advance the the version of uilib-native - We have a dedicated package (under lib/package.json) because of the engine and the fact they responsible for all native versions.
We need of course to update this version in the engine

Inbal-Tish · 2022-02-15T10:33:10Z

lib/package.json

Thanks! I added a version bump to this PR. I'll open a PR to the engine and add it to the ticket

Inbal-Tish added 3 commits February 15, 2022 09:46

fix keyboard translation with TabBar

52806b3

check tabbar

894b3e2

remove log

cbc5d0d

Inbal-Tish requested a review from ethanshar February 15, 2022 09:09

Inbal-Tish assigned ethanshar Feb 15, 2022

ethanshar approved these changes Feb 15, 2022

View reviewed changes

bumping lib version

76075f2

Inbal-Tish requested a review from ethanshar February 15, 2022 11:12

Inbal-Tish merged commit 61921b4 into master Feb 15, 2022

Inbal-Tish deleted the fix/KeyboardTrackingView_ios branch March 14, 2022 12:37