TabController - move to design tokens #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
reviewed
Feb 16, 2022
| }, | ||
| containerShadow: { | ||
| ...Platform.select({ | ||
| ios: { | ||
| shadowColor: Colors.grey10, | ||
| shadowColor: Colors.black, |
There was a problem hiding this comment.
Private has this as black, and it removed the need for a new token, WDYT?
There was a problem hiding this comment.
But this way it'll be black in all modes.
Maybe $backgroundNeutralHeavy will do the work here since it's dark in light mode, and light in dark mode..
There was a problem hiding this comment.
We still don't have a solution for shadows AFAIK, so if we're not handling this in private, why should this be different?
There was a problem hiding this comment.
Ohh so you just align the color to the private one?
There was a problem hiding this comment.
Not really align everything, but this specifically because otherwise it's a new token for this edge case...
lidord-wix
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TabController - move to design tokens
I did change the color slightly in two places so we won't need to create a new token (this is aligned with private, so it seems ok).
Changelog
TabController - move to design tokens