Skip to content

Infra/Settings and playground screens migrations #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Infra/Settings and playground screens migrations #1857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo/src/screens/PlaygroundScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default class PlaygroundScreen extends Component {
return (
<View bg-grey80 flex padding-20>
<View marginT-20>
<TextField placeholder="Placeholder" />
<TextField migrate placeholder="Placeholder" />
</View>
<Card height={100} center padding-20>
<Text text50>Playground Screen</Text>
Expand Down
6 changes: 4 additions & 2 deletions demo/src/screens/SettingsScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,13 @@ class SettingsScreen extends Component {
testID={'uilib.defaultScreenPicker'}
placeholder="Pick default screen..."
showSearch
value={defaultScreen}
value={defaultScreen?.value}
label={defaultScreen?.label}
onChange={this.setDefaultScreen}
migrateTextField
>
{_.map(filteredScreens, screen => (
<Picker.Item key={screen.value} value={screen}/>
<Picker.Item key={screen.value} value={screen.value} label={screen.label}/>
))}
</Picker>

Expand Down