Fix/ add tintColor to tabbar gradient #1867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
Feb 27, 2022
| @@ -117,7 +117,7 @@ interface Props extends TabControllerBarProps, BaseComponentInjectedProps, Forwa | |||
| children?: ChildProps[] | ChildProps; | |||
| } | |||
|
|
|||
| const FADER_PROPS = {size: 76}; | |||
| const FADER_PROPS = {size: 76, tintColor: Colors.$backgroundElevated}; | |||
There was a problem hiding this comment.
I feel like this is not as prominent as the regular scheme, probably because there's less contrast with the text color.
Perhaps this should be Colors.$backgroundDefault?
M-i-k-e-l
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the fader color in dark mode TabBar
Changelog
Fix the fader color in dark mode TabBar