Infra/picker screen ts #1888
Merged
Infra/picker screen ts #1888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ethanshar Looks fine. Is there a reason to keep Picker.d.ts in typings/components? Why not use only types.ts in Picker dir? |
Inbal-Tish
reviewed
Mar 13, 2022
typings/globalTypes.d.ts
Outdated
| type Constructor<T, TA = any> = new(...args: TA[]) => T; | ||
| type ExtendTypeWith<T extends Constructor<any>, OtherObject extends object> = Constructor<InstanceType<T> & OtherObject, ConstructorParameters<T>>; | ||
| type Constructor<T, TA = any> = new (...args: TA[]) => T; | ||
| type ExtendTypeWith<T extends Constructor<any>, OtherObject extends object> = Constructor< |
There was a problem hiding this comment.
I don't see why break the line here...
removed the old typings file |
Inbal-Tish
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate example PickerScreen to TS
Changelog
Migrate example PickerScreen to TS