Infra/ revese color palettes in dark mode #1893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Mar 15, 2022
src/style/colors.ts
Outdated
| @@ -11,6 +11,7 @@ import Scheme, {Schemes, SchemeType} from './scheme'; | |||
|
|
|||
| export class Colors { | |||
| [key: string]: any; | |||
| shouldSupportDarkMode = false; | |||
There was a problem hiding this comment.
Can you check if you can mark this class member as private as private houldSupportDarkMode = false;
I think it will avoid having this member exposed to the user
src/style/colors.ts
Outdated
| @@ -132,7 +134,8 @@ export class Colors { | |||
| const colorKey = _.findKey(this, (_value, key) => this[key] === color); | |||
|
|
|||
| if (colorKey) { | |||
| const requiredColorKey = `${colorKey.slice(0, -2)}${tintKey}`; | |||
| const key = this.shouldSupportDarkMode && Scheme.getSchemeType() === 'dark' ? 90 - Number(tintKey) : tintKey; | |||
There was a problem hiding this comment.
I'm not so sure about the 90 - Number(tintKey) part?
Its purpose is to reverse the key to the dark mode key?
Since now we added keys like 1 and 5 it's possible we'll get a dark-mode key of 89 or 85
ethanshar
reviewed
Mar 16, 2022
src/style/colors.ts
Outdated
| @@ -143,6 +147,24 @@ export class Colors { | |||
| return this.getTintedColorForDynamicHex(color, tintKey); | |||
| } | |||
|
|
|||
| getInvertedTintKey(tintKey: string | number) { | |||
There was a problem hiding this comment.
can I offer a code improvement (:
You can create an array of our keys ([1, 5, 10, 20, 30, ..., 80])
Then use array.indexOf to detect the given key index, revert the index (as you did before) and return the inverted key..
ethanshar
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverse color palettes in dark mode
WOAUILIB-2585
Changelog
Reverse color palettes in dark mode