Skip to content

SvgImage - remove tintColor to fix Android crash #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2022
Merged

SvgImage - remove tintColor to fix Android crash #1903

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f61c04d
SvgImage - remove tintColor to fix Android crash
M-i-k-e-l Mar 16, 2022
67ac07d
Rename
M-i-k-e-l Mar 16, 2022
08dd406
Add comment
M-i-k-e-l Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions generatedTypes/src/components/svgImage/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
/// <reference types="react" />
export interface SvgImageProps {
/**
* the asset tint
*/
tintColor?: string | null;
data: any;
}
declare function SvgImage(props: SvgImageProps): JSX.Element | null;
Expand Down
7 changes: 6 additions & 1 deletion src/components/svgImage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,16 @@ const SvgCssUri = SvgPackage?.SvgCssUri;
// const SvgProps = SvgPackage?.SvgProps; TODO: not sure how (or if) we can use their props

export interface SvgImageProps {
/**
* the asset tint
*/
tintColor?: string | null;
data: any; // TODO: I thought this should be string | React.ReactNode but it doesn't work properly
}

function SvgImage(props: SvgImageProps) {
const {data, ...others} = props;
// eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars
const {data, tintColor, ...others} = props;

if (!SvgXml) {
// eslint-disable-next-line max-len
Expand Down