Fix/ migrate callback refs to object #1912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
requested changes
Mar 20, 2022
src/components/slider/index.tsx
Outdated
| @@ -305,12 +305,12 @@ export default class Slider extends PureComponent<SliderProps, State> { | |||
| const nonOverlappingTrackWidth = trackSize.width - this.initialThumbSize.width; | |||
| const _x = Constants.isRTL && disableRTL ? nonOverlappingTrackWidth - x : x; // adjust for RTL | |||
| this._thumbStyles.left = trackSize.width === 0 ? _x : (_x * nonOverlappingTrackWidth) / trackSize.width; // do not render above prefix\suffix icon\text | |||
| this.thumb.setNativeProps(this._thumbStyles); | |||
| this.thumb.current?.setNativeProps(this._thumbStyles); | |||
| } | |||
|
|
|||
| if (this.minTrack) { | |||
There was a problem hiding this comment.
You might need to check that this.minTrack.current is not undefined and not just this.minTrack
| @@ -327,7 +327,7 @@ export default class Slider extends PureComponent<SliderProps, State> { | |||
|
|
|||
| const activeOrInactiveStyle = !this.props.disabled ? (start ? activeStyle : style) : {}; | |||
| this._thumbStyles.style = _.omit(activeOrInactiveStyle, 'height', 'width'); | |||
| this.thumb.setNativeProps(this._thumbStyles); | |||
| this.thumb.current?.setNativeProps(this._thumbStyles); | |||
There was a problem hiding this comment.
Same here, in the check above you probably need to check this.thumb.current
Technically this.thumb is never undefined cause it is {current: undefined} when initialized
ethanshar
approved these changes
Mar 21, 2022
lidord-wix
added a commit
that referenced
this pull request
Mar 21, 2022
* migrate callback refs to object * fix ref checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate callback refs to object, to resolve TS errors
Changelog
Migrate callback refs to object, to resolve TS errors