Skip to content

Avatar and Text - design tokens #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2022
Merged

Avatar and Text - design tokens #1917

merged 5 commits into from
Apr 3, 2022

Conversation

M-i-k-e-l
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l commented Mar 23, 2022 •
edited
Loading

Description

Avatar - design tokens

WOAUILIB-2596

Changelog

Avatar - design tokens

@M-i-k-e-l M-i-k-e-l requested a review from lidord-wix March 23, 2022 08:07
lidord-wix
lidord-wix reviewed Mar 28, 2022
View reviewed changes
Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, also please add $textDefault to the screen titles so it'll change in dark mode

@M-i-k-e-l M-i-k-e-l requested a review from lidord-wix April 3, 2022 09:42
@lidord-wix
Copy link
Contributor

Small comment, also please add $textDefault to the screen titles so it'll change in dark mode

@M-i-k-e-l I think you missed the comment about the screen titles :)

@M-i-k-e-l
Copy link
Collaborator Author

@M-i-k-e-l I think you missed the comment about the screen titles :)

Fixed

@lidord-wix lidord-wix merged commit 45f27d9 into master Apr 3, 2022
@M-i-k-e-l M-i-k-e-l deleted the infra/avatar-and-text-design-tokens branch April 3, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidord-wix lidord-wix lidord-wix approved these changes

Assignees

@lidord-wix lidord-wix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @lidord-wix