Skip to content

Feat/sortable grid list component #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 6, 2022
Merged

Feat/sortable grid list component #1918

merged 18 commits into from
Apr 6, 2022

Conversation

ethanshar
Copy link
Collaborator

@ethanshar ethanshar commented Mar 23, 2022 •
edited
Loading

Description

Based on #1914

Implement a SortableGridList component based on GridList logic
This component is using ScrollView and not a FlatList due to gesture constraints

Changelog

New SortableGridList component!

@ethanshar ethanshar requested a review from M-i-k-e-l March 24, 2022 16:53
uncle-bot
uncle-bot previously approved these changes Mar 24, 2022
View reviewed changes
@ethanshar ethanshar marked this pull request as ready for review March 26, 2022 13:45
@ethanshar ethanshar added the Important for Next Release PR that must be included in the release version label Mar 29, 2022
@ethanshar ethanshar requested a review from lidord-wix April 3, 2022 13:45
@ethanshar ethanshar assigned lidord-wix and unassigned M-i-k-e-l Apr 3, 2022
lidord-wix
lidord-wix reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few small comments, and:

  • please add an API file.
  • worth mentioning somewhere that it supports only square items.
  • don't forget to make a private PR for exporting the new components and adding the screens once this one is ready.

@lidord-wix lidord-wix merged commit 3f36c7a into master Apr 6, 2022
@ethanshar ethanshar deleted the feat/SortableGridListComponent branch June 13, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidord-wix lidord-wix lidord-wix approved these changes

@uncle-bot uncle-bot uncle-bot left review comments

@M-i-k-e-l M-i-k-e-l Awaiting requested review from M-i-k-e-l

Assignees

@lidord-wix lidord-wix

Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethanshar @uncle-bot @lidord-wix @M-i-k-e-l