Fix/tab controller safe area and indicator width #1923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Mar 30, 2022
| return Constants.windowWidth - (useSafeArea && Constants.isIphoneX ? left + right : 0); | ||
| }; | ||
|
|
||
| const [screenWidth, setScreenWidth] = useState<number>(getScreenWidth()); |
There was a problem hiding this comment.
It's a little weird the method getScreenWidth is above the useState.
I suggest moving the function out of the component code, nothing fancy, it can be top/bottom of the file
ethanshar
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TabController - support safe area and constant indicator width
Changelog
Fixes #1746 - TabController - support safe area (useSafeArea) and constant indicator width (indicatorWidth)