POC Export of testkits #1925
Merged
POC Export of testkits #1925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marik22312
commented
Mar 31, 2022
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
A small hack to make the testkits available under
import {} from 'react-native-ui-lib/testkit'
There was a problem hiding this comment.
Huge thanks to @amitdahan for helping out with this one
marik22312
commented
Mar 31, 2022
| return { | ||
| accessible: true, | ||
| accessibilityRole: 'switch', | ||
| accessibilityStates: disabled ? ['disabled'] : value ? ['checked'] : ['unchecked'], | ||
| accessibilityState: { |
There was a problem hiding this comment.
Changed accessibilityState to follow Accessibility docs of react-native
https://reactnative.dev/docs/accessibility#accessibilitystate
There was a problem hiding this comment.
Double checked with building & running the app locally, I see no errors regarding this change so I guess it's ok
There was a problem hiding this comment.
👍
I tried testing with Accessibility Inspector locally but it doesn't show the state value so I'll verify again on real device after we merge
added 16 commits
April 3, 2022 11:21
marik22312
force-pushed
the
poc/exported-testkit
branch
from
3e38eb8 to
79ab237
Compare
ethanshar
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposed testkits to consumers via
react-native-ui-lib/testkitThe main approach here was to create the testkit and test the component with it's testkit.
this way we'll have a good coverage of both the component, and the testkit in a single test file
if the component breaks, the test will fail
if there's some changes under the hood and the testkit is not updated, the tests will also fail
Changelog
Expose initial POC of testkit for our components