Skip to content

TabController - design tokens - fixes #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 11, 2022
Merged

TabController - design tokens - fixes #1935

merged 6 commits into from
Apr 11, 2022

Conversation

M-i-k-e-l
Copy link
Collaborator

Description

TabController - design tokens - fixes

Changelog

TabController - design tokens - fixes

@M-i-k-e-l M-i-k-e-l requested a review from lidord-wix April 4, 2022 09:30
lidord-wix
lidord-wix reviewed Apr 4, 2022
View reviewed changes
Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment

src/components/tabController/TabBar.tsx
@@ -117,7 +117,7 @@ interface Props extends TabControllerBarProps, BaseComponentInjectedProps, Forwa
children?: ChildProps[] | ChildProps;
}

const FADER_PROPS = {size: 76, tintColor: Colors.$backgroundDefault};
const FADER_PROPS = {size: 76, tintColor: Colors.$backgroundElevated};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about it?
I used the backgroundElevated originally and you said it looks better with backgroundDefault

Copy link
Collaborator Author

@M-i-k-e-l M-i-k-e-l Apr 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, I'll ask UX (I don't think they tokenized it)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be $backgroundElevated but will be handled within the Fader

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that the default fader color should be $backgroundElevated and not $backgroundDefault?
maybe it should be $backgroundDefault and only here we should override it with $backgroundElevated..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what Yulia said in the relevant channel (can't link here).
In any case, if there will be errors we can fix them later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@M-i-k-e-l M-i-k-e-l requested a review from lidord-wix April 9, 2022 08:41
@lidord-wix lidord-wix merged commit 7607a83 into master Apr 11, 2022
@M-i-k-e-l M-i-k-e-l deleted the infra/design-tokens-tab-controller-fixes branch April 11, 2022 07:41
lidord-wix pushed a commit that referenced this pull request Apr 17, 2022
@M-i-k-e-l @lidord-wix
TabController - design tokens - fixes (#1935)
0431a56 
* TabController - design tokens - fixes

* Fader color will be handled within Fader

* Revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidord-wix lidord-wix lidord-wix approved these changes

Assignees

@lidord-wix lidord-wix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @lidord-wix