enh: allow Incubator.WheelPicker to take custom properties for the Fader #1947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Apr 6, 2022
Asgaroth
force-pushed
the
wheelpicker-tint
branch
2 times, most recently
from
9f0a3cf to
8a7114d
Compare
ethanshar
reviewed
Apr 28, 2022
Asgaroth
changed the title
ethanshar
approved these changes
May 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incubator.WheelPickerdid not allow changing the fader tint. Which makes it hard to style for Dark modeThis PR allows users to pass in
faderPropsto theIncubator.WheelPickerand forward them to the<Fader />component.Changelog
faderPropstoIncubator.WheelPickerand forward them to the<Fader />component.