Fix PlatfromColor issue in TabController.TabBarItem #1955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Apr 10, 2022
| @@ -131,6 +131,9 @@ export default function TabBarItem({ | |||
| const sharedLabelStyle = useSharedValue(JSON.parse(JSON.stringify(labelStyle))); | |||
| const sharedSelectedLabelStyle = useSharedValue(JSON.parse(JSON.stringify(selectedLabelStyle))); | |||
|
|
|||
| const inactiveColor = useRef(_.cloneDeep(labelColor)); | |||
| const activeColor = useRef(_.cloneDeep(!ignore ? selectedLabelColor : inactiveColor.current)); | |||
There was a problem hiding this comment.
I would give these consts a more specific name like 'animatedLabelColor' and 'animatedSelectedLabelColor' so it will be extra clear what this clone is for.
There was a problem hiding this comment.
I think the name is suffice, but I will add a note instead that explains the reason we keep it like this
Inbal-Tish
approved these changes
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a bug when using a color that connected to a PlatformColor in useAnimatedStyle hook.
I opened a issue here that explain it better software-mansion/react-native-reanimated#3164
Anyway, for now, in order to resolve it, I clone the colors in the TabBarItem code.
Changelog
Fix usages of PlatformColor in TabController TabBaritem