Upgrade reanimated and gesture-handler to latest version #1977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
Apr 14, 2022
There was a problem hiding this comment.
There's an @ts-expect-error with an error in SegmentedControl
Found one bug: in the new Dialog, on Android the Dialog's height is not taking the full height it can (up to maxHeight), not sure why it happens (already clean-installed to the previous version to verify it's a regression, so let me know if you want me to dig into this).
|
@M-i-k-e-l |
M-i-k-e-l
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade reanimated and gesture-handler to latest versions to make sure there are not issues
(this is so we can safely upgrade later in the engine)
Changelog
Upgrade reanimated and gesture-handler to latest versions in our demo app