Skip to content

Keyboard components - add docs #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 24, 2022
Merged

Keyboard components - add docs #1984

merged 5 commits into from
Apr 24, 2022

Conversation

M-i-k-e-l
Copy link
Collaborator

Description

Keyboard components - add docs

Changelog

Keyboard components - add docs

lidord-wix
lidord-wix reviewed Apr 17, 2022
View reviewed changes
lib/components/Keyboard/KeyboardInput/keyboardAccessoryView.json Outdated
@@ -0,0 +1,97 @@
{
"name": "KeyboardAccessoryView",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding 'api' to the file name

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not mean to set you as reviewer, 10x :D

lib/components/Keyboard/KeyboardInput/keyboardRegistry.json Outdated
@@ -0,0 +1,50 @@
{
"name": "KeyboardRegistry",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding 'api' to the file name

@M-i-k-e-l M-i-k-e-l requested a review from lidord-wix April 17, 2022 09:18
@lidord-wix lidord-wix removed their request for review April 17, 2022 10:39
Inbal-Tish
Inbal-Tish reviewed Apr 24, 2022
View reviewed changes
lib/components/Keyboard/KeyboardTracking/keyboardAwareInsetsView.api.json Outdated
"category": "keyboard",
"description": "Used to add an inset when a keyboard is used and might hide part of the screen.",
"notes": "This view is useful only for iOS.",
"extends": ["KeyboardTracking"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extends KeyboardTrackingView

Inbal-Tish
Inbal-Tish reviewed Apr 24, 2022
View reviewed changes
lib/components/Keyboard/KeyboardTracking/KeyboardTrackingView/keyboardTracking.api.json Outdated
@@ -0,0 +1,37 @@
{
"name": "KeyboardTracking",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name: KeyboardTrackingView

Inbal-Tish
Inbal-Tish reviewed Apr 24, 2022
View reviewed changes
lib/components/Keyboard/KeyboardInput/keyboardAccessoryView.api.json
@@ -0,0 +1,97 @@
{
"name": "KeyboardAccessoryView",
"category": "keyboard",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extends: KeyboardTrackingView

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It technically does, but for the user it is not true (all KeyboardTrackingView props are passed literally in the KeyboardAccessoryViewProps and there's no extends \ others used).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... I'm not sure why thought

M-i-k-e-l and others added 2 commits April 24, 2022 10:12
@M-i-k-e-l @Inbal-Tish
Fix typo
27d1705 
Co-authored-by: Inbal Tish <[email protected]>
@M-i-k-e-l
Fix names
e788742
@M-i-k-e-l M-i-k-e-l requested a review from Inbal-Tish April 24, 2022 07:14
@Inbal-Tish
Copy link
Collaborator

@M-i-k-e-l Approved. The build fails so merge when fixed

@M-i-k-e-l M-i-k-e-l merged commit d99ea6a into master Apr 24, 2022
@M-i-k-e-l M-i-k-e-l deleted the docs/keyboard-components branch April 24, 2022 08:34
lidord-wix pushed a commit that referenced this pull request Apr 24, 2022
@M-i-k-e-l @Inbal-Tish @lidord-wix
Keyboard components - add docs (#1984)
0adfc05 
* Keyboard components - add docs

* Damn you copy-paste

* Fix typo

Co-authored-by: Inbal Tish <[email protected]>

* Fix names

Co-authored-by: Inbal Tish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inbal-Tish Inbal-Tish Inbal-Tish approved these changes

@lidord-wix lidord-wix lidord-wix approved these changes

Assignees

@Inbal-Tish Inbal-Tish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M-i-k-e-l @Inbal-Tish @lidord-wix