Expose new impertive methods on picker #1988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
reviewed
Apr 18, 2022
| @@ -12,6 +12,12 @@ export interface RenderCustomOverlayProps { | |||
| toggleExpandable: () => void; | |||
| } | |||
|
|
|||
| export interface ExpandableOverlayMethods { | |||
There was a problem hiding this comment.
You can extend this interface in the one above (RenderCustomOverlayProps), just for making it look better
| @@ -38,6 +39,7 @@ const filters = [ | |||
| ]; | |||
|
|
|||
| export default class PickerScreen extends Component { | |||
| picker = React.createRef(); | |||
There was a problem hiding this comment.
Consider exporting the relevant type and adding it here (for autocomplete and to resolve the ts error from line 290)
There was a problem hiding this comment.
I exported the type.
Resolving the TS error on line 290 is a little more complicated than that, but at least there's now the autocomplete on the ref
lidord-wix
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose new imperative methods on picker component to allow opening expandable modal
WOAUILIB-2573
Changelog
Expose new imperative methods on picker component to allow opening expandable modal (openExpandable, closeExpandable, toggleExpandable)