Enable useNative when passing activeScale and add its type #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
reviewed
Apr 19, 2022
| const {borderRadius, paddings, margins, alignments, flexStyle} = modifiers; | ||
|
|
||
| if (useNative) { | ||
| if (useNative || !!activeScale) { |
There was a problem hiding this comment.
It's a rare case but it won't work if the activeScale is equal to 0 even though it's a valid value.
There was a problem hiding this comment.
Fixed
Though passing 0 to activeScale is really weird (:
lidord-wix
approved these changes
Apr 19, 2022
lidord-wix
pushed a commit
that referenced
this pull request
Apr 24, 2022
* Enable useNative when passing activeScale and add its type * Fix check on activeScale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose activeScale prop and enable useNative by default when using it
WOAUILIB-2221
Changelog
Expose activeScale prop and enable useNative by default when using it