Skip to content

eslint - function deprecation - fix usage from source #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

M-i-k-e-l
Copy link
Collaborator

Description

eslint - function deprecation - fix usage from source
WOAUILIB-2588

Changelog

eslint - function deprecation - fix usage from source

Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, you can merge one you see the comment I left :)

@@ -3,7 +3,8 @@ const rule = require('../../../lib/rules/prop-value-shape-deprecation');
const deprecationsJson = require('../../prop-value-shape-deprecation.json');
const fs = require('fs');
const bigExampleValid = fs.readFileSync('../demo/src/screens/componentScreens/ChipScreen.tsx', 'utf8');
const bigExampleError = fs.readFileSync('../demo/src/screens/componentScreens/PickerScreen.js', 'utf8');
// TODO: parsing error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest opening a ticket for it..

@M-i-k-e-l M-i-k-e-l merged commit 6e89e1b into master Apr 27, 2022
@M-i-k-e-l M-i-k-e-l deleted the fix/eslint-function-deprecation-from-source branch April 27, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants