Handle data change and reset sortable grid list order #2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
added
the
Important for Next Release
lidord-wix
reviewed
May 4, 2022
You're right! It's all related to this issue I opened to reanimated library -> software-mansion/react-native-reanimated#3224 Anyway, it should be fixed now in my last commit, I hope I didn't miss anything. |
lidord-wix
approved these changes
May 9, 2022
Comment on lines
59
to
73
| if (newOrder === initialIndex.value) { | ||
| if (dataManuallyChanged.value) { | ||
| translateX.value = 0; | ||
| translateY.value = 0; | ||
| } else { | ||
| translateX.value = withTiming(0, animationConfig); | ||
| translateY.value = withTiming(0, animationConfig); | ||
| } | ||
| dataManuallyChanged.value = false; | ||
| } else if (newOrder !== prevOrder) { | ||
| const translation = getTranslationByOrderChange(newOrder, prevOrder); | ||
| translateX.value = withTiming(translateX.value + translation.x, animationConfig); | ||
| translateY.value = withTiming(translateY.value + translation.y, animationConfig); | ||
| } | ||
| } |
There was a problem hiding this comment.
I know we don't use to do it, but I found the conditions here a bit confusing.. consider adding a comment for every condition that explains the cases that are relevant to this condition..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support dynamic data in SortableGridList
I'm aware this is a breaking change, but due to the fact it's a new component and that without this feature it doesn't work well, let's push it and not wait for next major version
The main change here, is that we now identify each item by an id prop the user pass (instead of the index)
This way we can handle data change (remove/add) of items without breaking the logic of the sorting
Changelog
Breaking: Support dynamic data in SortableGridList
This requires to pass
idprop for each item