Skip to content

Design Tokens - Wizard #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2022
Merged

Design Tokens - Wizard #2026

merged 2 commits into from
May 3, 2022

Conversation

M-i-k-e-l
Copy link
Collaborator

Description

Design Tokens - Wizard
WOAUILIB-2724

Changelog

Design Tokens - Wizard

error: {color: Colors.red30, icon: exclamationSmall, enabled: true, accessibilityInfo: 'Validation Error'},
skipped: {color: Colors.red30, enabled: true, accessibilityInfo: 'Not completed'},
enabled: {color: Colors.$textNeutralHeavy, circleColor: Colors.$outlineDisabled, enabled: true},
disabled: {color: Colors.$textDisabled, circleColor: Colors.outlineDefault},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
disabled: {color: Colors.$textDisabled, circleColor: Colors.outlineDefault},
disabled: {color: Colors.$textDisabled, circleColor: Colors.$outlineDisabled},

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it changed to grey60 so you're using the $outlineDefault token? anyways your missing the '$'

Copy link
Collaborator Author

@M-i-k-e-l M-i-k-e-l May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new design page for tokenized components: Wizard
It's from there (fixed)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there both disabled and enabled borderline have the same token...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the bottom part, all the types are there.
You might have looked at enabled and completed.

disabled: {color: Colors.grey50, circleColor: Colors.grey60},
error: {color: Colors.red30, icon: exclamationSmall, enabled: true, accessibilityInfo: 'Validation Error'},
skipped: {color: Colors.red30, enabled: true, accessibilityInfo: 'Not completed'},
enabled: {color: Colors.$textNeutralHeavy, circleColor: Colors.$outlineDisabled, enabled: true},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
enabled: {color: Colors.$textNeutralHeavy, circleColor: Colors.$outlineDisabled, enabled: true},
enabled: {color: Colors.$textNeutralHeavy, circleColor: Colors.$outlineDefault, enabled: true},

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it changed to grey50 so you're using the $outlineDisabled token?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's set to $outlineNeutralMedium which is $outlineDisabled

color: Colors.grey30,
circleColor: Colors.grey60,
color: Colors.$iconNeutral,
circleColor: Colors.$outlineDisabled,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
circleColor: Colors.$outlineDisabled,
circleColor: Colors.$outlineDefault,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it changed to grey50 so you're using the $outlineDisabled token?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's set to $outlineNeutralMedium which is $outlineDisabled

@@ -118,7 +118,7 @@ export default asBaseComponent<WizardStepProps>(WizardStep);
const styles = StyleSheet.create({
connector: {
borderWidth: 0.5,
borderColor: Colors.grey60
borderColor: Colors.$outlineDisabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it changed to grey50 so you're using the $outlineDisabled token?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other comments :)

@M-i-k-e-l M-i-k-e-l requested a review from Inbal-Tish May 3, 2022 12:33
@Inbal-Tish Inbal-Tish merged commit fe20914 into master May 3, 2022
@M-i-k-e-l M-i-k-e-l deleted the infra/design-tokens-wizard branch May 3, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants