-
Notifications
You must be signed in to change notification settings - Fork 734
Design Tokens - Wizard #2026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Tokens - Wizard #2026
Conversation
error: {color: Colors.red30, icon: exclamationSmall, enabled: true, accessibilityInfo: 'Validation Error'}, | ||
skipped: {color: Colors.red30, enabled: true, accessibilityInfo: 'Not completed'}, | ||
enabled: {color: Colors.$textNeutralHeavy, circleColor: Colors.$outlineDisabled, enabled: true}, | ||
disabled: {color: Colors.$textDisabled, circleColor: Colors.outlineDefault}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabled: {color: Colors.$textDisabled, circleColor: Colors.outlineDefault}, | |
disabled: {color: Colors.$textDisabled, circleColor: Colors.$outlineDisabled}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it changed to grey60 so you're using the $outlineDefault token? anyways your missing the '$'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a new design page for tokenized components: Wizard
It's from there (fixed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there both disabled and enabled borderline have the same token...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at the bottom part, all the types are there.
You might have looked at enabled
and completed
.
disabled: {color: Colors.grey50, circleColor: Colors.grey60}, | ||
error: {color: Colors.red30, icon: exclamationSmall, enabled: true, accessibilityInfo: 'Validation Error'}, | ||
skipped: {color: Colors.red30, enabled: true, accessibilityInfo: 'Not completed'}, | ||
enabled: {color: Colors.$textNeutralHeavy, circleColor: Colors.$outlineDisabled, enabled: true}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enabled: {color: Colors.$textNeutralHeavy, circleColor: Colors.$outlineDisabled, enabled: true}, | |
enabled: {color: Colors.$textNeutralHeavy, circleColor: Colors.$outlineDefault, enabled: true}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it changed to grey50 so you're using the $outlineDisabled token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's set to $outlineNeutralMedium which is $outlineDisabled
color: Colors.grey30, | ||
circleColor: Colors.grey60, | ||
color: Colors.$iconNeutral, | ||
circleColor: Colors.$outlineDisabled, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
circleColor: Colors.$outlineDisabled, | |
circleColor: Colors.$outlineDefault, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it changed to grey50 so you're using the $outlineDisabled token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's set to $outlineNeutralMedium which is $outlineDisabled
@@ -118,7 +118,7 @@ export default asBaseComponent<WizardStepProps>(WizardStep); | |||
const styles = StyleSheet.create({ | |||
connector: { | |||
borderWidth: 0.5, | |||
borderColor: Colors.grey60 | |||
borderColor: Colors.$outlineDisabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it changed to grey50 so you're using the $outlineDisabled token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other comments :)
Description
Design Tokens - Wizard
WOAUILIB-2724
Changelog
Design Tokens - Wizard