Infra/ designTokens disabled Slider #2033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
May 8, 2022
| @@ -621,6 +622,9 @@ const styles = StyleSheet.create({ | |||
| shadowRadius: SHADOW_RADIUS, | |||
| elevation: 2 | |||
| }, | |||
| disabledThumb: { | |||
| borderColor: Colors.$backgroundElevated | |||
There was a problem hiding this comment.
Why this token is only for the disabled thumb? The active one is white (as defined in line 618), shouldn't it be tokenized as well?
There was a problem hiding this comment.
For the active slider, the thumb should be white for both dark and light modes.
For the disabled slider, it should be elevated (white in light mode and grey1 in dark)
Inbal-Tish
approved these changes
May 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix disabled slider border color - design tokens
Changelog
Fix disabled slider border color - design tokens