Fixed the ChipsInput field trimmed bug #2183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m the Input component style.
|
Ethan please take a look at this PR, I removed the felxGrow prop from the Input component that fix the bug. |
ethanshar
reviewed
Aug 14, 2022
src/incubator/TextField/Input.tsx
Outdated
| @@ -45,7 +44,7 @@ const Input = ({ | |||
|
|
|||
| const styles = StyleSheet.create({ | |||
| input: { | |||
| flexGrow: 1, | |||
There was a problem hiding this comment.
I checked why we added this flexGrow.
We did it in this PR
#1734
But unfortunately, I can't reproduce the bug it was meant to fix.
We can merge the PR and worse case we can revert if the bug appear again.
Another option is to pass a style that overrides the flexGrow from the ChipsInput code.
What do you prefer to do?
ethanshar
reviewed
Aug 14, 2022
src/incubator/ChipsInput/index.tsx
Outdated
| @@ -142,6 +142,7 @@ const ChipsInput = forwardRef((props: ChipsInputProps, refToForward: React.Ref<a | |||
| ref={fieldRef} | |||
| leadingAccessory={chipList} | |||
| blurOnSubmit={false} | |||
| style={{flexGrow: undefined}} | |||
There was a problem hiding this comment.
Don't pass inline styles
It creates a new object ref every render which triggers subsequent re-renders for inner components that depends on this prop
ethanshar
approved these changes
Aug 15, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ChipsInput field get trimmed when inserting more than 1 line of chips.
Changelog
ChipsInput field get trimmed when inserting more than 1 line of chips.