-
Notifications
You must be signed in to change notification settings - Fork 734
Upgrade Expo Demo SDK #2306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Expo Demo SDK #2306
Conversation
I think you should upgrade to lastest version of expo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But it should be upgrade to newest version of expo and other dependency
@jeferson-sb |
@Vn-ChemGio hm that's odd It seems that unicorn-demo-app doesn't support React 18 (which is required for SDK 46). |
I also try with code from your commit
But got same issue -- It's seem an issue from unicon-demo-app only and it should be note in an separate issue The list of some screen has error with NAVIGATE
So your update is no problem, No need to downgrade to Expo 44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Vn-ChemGio Cool! I tried to scan the QR Code in Expo Go, but I got stuck in the splash screen saying "new update available, downloading..." on my android device. |
@jeferson-sb unfortunate, I don't have any android device on hand :D |
@M-i-k-e-l could you help to approve this PR |
@Vn-ChemGio I tried the iOS version but several things seem to be broken. Like e.g. |
@sapkra yeah I see this |
@ethanshar I make an upgrade in PR #2501 |
* Update dependence for expoExample * Update to make some screen available in example - DarkMode - ScrollBar - Marquee - NumberInput - WheelPicker - GridList] - SortableGridList - IncubatorSlider - IncubatorDialog - IncubatorToast - IncubatorExpandableOverlay - Modal - Timeline - WithScrollEnabler - WithScrollReached - Fader - GridView - Playground - KeyboardAwareScrollView Fix warning when upgrade to v7 in Product Page * Update version release and update expo QR code in readme
Description
Users can't install/run the expo demo app in either the app or snack due to Expo Go App only supports sdk > 44
and the current one is 42.00. This PR address these issues by bumping dependencies and updating necessary config files.
Couple notes:
Related issues: #2295, #2199
Changelog
Updates Expo Demo SDK to 46.0 and React 18