Skip to content

Upgrade Expo Demo SDK #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Conversation

jeferson-sb
Copy link
Contributor

@jeferson-sb jeferson-sb commented Oct 28, 2022

Description

Users can't install/run the expo demo app in either the app or snack due to Expo Go App only supports sdk > 44
and the current one is 42.00. This PR address these issues by bumping dependencies and updating necessary config files.

Couple notes:

  • The App under Snack link may need a manual update in RNULib snack account I think.
  • Need to publish the new version of unicorn-demo-app in NPM first so dependencies are correct.

Related issues: #2295, #2199

Changelog

Updates Expo Demo SDK to 46.0 and React 18

@Vn-ChemGio
Copy link
Contributor

I think you should upgrade to lastest version of expo
Currently is SDK 46.0.0

Copy link
Contributor

@Vn-ChemGio Vn-ChemGio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But it should be upgrade to newest version of expo and other dependency

@Vn-ChemGio
Copy link
Contributor

@jeferson-sb
I've try with expo in local
Its working well
But some example component in not working
Please check one times again!

@jeferson-sb
Copy link
Contributor Author

@Vn-ChemGio hm that's odd It seems that unicorn-demo-app doesn't support React 18 (which is required for SDK 46).
I'm having some issues trying to update that package locally, which components aren't working? Should I revert to 44?

@Vn-ChemGio
Copy link
Contributor

@Vn-ChemGio hm that's odd It seems that unicorn-demo-app doesn't support React 18 (which is required for SDK 46). I'm having some issues trying to update that package locally, which components aren't working? Should I revert to 44?

I also try with code from your commit

https://github.com/wix/react-native-ui-lib/pull/2306/commits/347159d5c25c6c1c99adb5e5578f03392869f000

But got same issue

--
Got the error
The action 'NAVIGATE' with payload {"name":"Playground"} was not handled by any navigator.

It's seem an issue from unicon-demo-app only and it should be note in an separate issue


The list of some screen has error with NAVIGATE

  • Playground
  • Dark Mode
  • ScrollBar
    -TextField
    .....

So your update is no problem, No need to downgrade to Expo 44

Copy link
Contributor

@Vn-ChemGio Vn-ChemGio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vn-ChemGio
Copy link
Contributor

I've release the update to expo go
You can test by scan QR code bellow
-iOS:
image

  • android:
    image

@jeferson-sb
Copy link
Contributor Author

@Vn-ChemGio Cool! I tried to scan the QR Code in Expo Go, but I got stuck in the splash screen saying "new update available, downloading..." on my android device.

@Vn-ChemGio
Copy link
Contributor

@jeferson-sb unfortunate, I don't have any android device on hand :D
Need anybody check it agian

@Vn-ChemGio
Copy link
Contributor

@M-i-k-e-l could you help to approve this PR

@sapkra
Copy link

sapkra commented Nov 4, 2022

@Vn-ChemGio I tried the iOS version but several things seem to be broken. Like e.g. TextField doesn't even open and TextField (new) leads to a crash of the entire Expo Go app.

@Vn-ChemGio
Copy link
Contributor

@sapkra yeah I see this
Not only Textfield had been crash, some other had seem issue.
But this may an issue by unicon-demo-app
And should be fix separate

This PR only for release new update to compatitible with lastest version of Expo for demo, because curently demo had been outdate, and can”t be run in present

@ethanshar ethanshar merged commit 874de7e into wix:master Nov 15, 2022
@Vn-ChemGio
Copy link
Contributor

@ethanshar I make an upgrade in PR #2501
For resolve issue in this PR
Could you check and merge

ethanshar pushed a commit that referenced this pull request Feb 27, 2023
* Update dependence for expoExample

* Update to make some screen available in example
- DarkMode
- ScrollBar
- Marquee
- NumberInput
- WheelPicker
- GridList]
- SortableGridList
- IncubatorSlider
- IncubatorDialog
- IncubatorToast
- IncubatorExpandableOverlay
- Modal
- Timeline
- WithScrollEnabler
- WithScrollReached
- Fader
- GridView
- Playground
- KeyboardAwareScrollView
Fix warning when upgrade to v7 in Product Page

* Update version release and update expo QR code in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants