getTintColor support options, should reverse on dark prop #2321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Nov 9, 2022
ethanshar
reviewed
Nov 14, 2022
src/style/colors.ts
Outdated
| @@ -162,7 +163,8 @@ export class Colors { | |||
| return validColors ? undefined : results[0]; | |||
| } | |||
|
|
|||
| getColorTint(colorValue: string | OpaqueColorValue, tintKey: string | number) { | |||
| getColorTint(colorValue: string | OpaqueColorValue, tintKey: string | number, options?: GetColorTintOptions) { | |||
| const avoidReverseOnDark = !!options?.shouldReverseOnDark; | |||
There was a problem hiding this comment.
I think you misunderstood me here..
What I meant is that the option name will be avoidReverseOnDark, this way you don't need to do any special manipulation, and if the user passes nothing it will behave as we meant to
ethanshar
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getTintColor support options object with should reverse on dark prop.
Changelog
getTintColor support options object with should reverse on dark prop for the new Loader logic - Theme preset.