ColorPicker now support backgroundColor prop #2328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
requested review from
Inbal-Tish
and removed request for
ethanshar
Inbal-Tish
reviewed
Nov 15, 2022
Inbal-Tish
reviewed
Nov 15, 2022
Inbal-Tish
reviewed
Nov 15, 2022
Inbal-Tish
reviewed
Nov 20, 2022
| return this.usePagination ? this.renderPaginationContent() : this.renderScrollableContent(); | ||
| const {backgroundColor} = this.props; | ||
| return ( | ||
| <View flex style={{backgroundColor}}> |
There was a problem hiding this comment.
Why do we need this View wrapper?
Inbal-Tish
reviewed
Nov 21, 2022
Inbal-Tish
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ColorPicker now supports backgroundColor prop.
Changelog
ColorPicker now supports backgroundColor prop.