Fix marquee screen now have scroll view #2340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
reviewed
Nov 21, 2022
| <View marginV-s2> | ||
| {renderBooleanOption.call(this, 'Direction Horizontal: Left To Right/Right To Left', 'directionHorizontal')} | ||
| {renderBooleanOption.call(this, 'Direction Vertical: Bottom To Up/Up To Bottom', 'directionVertical')} | ||
| <ScrollView> |
There was a problem hiding this comment.
Why not replace the wrapping View with a ScrollView?
There was a problem hiding this comment.
You're right I'll just pass the style to the ScrollView
lidord-wix
approved these changes
Nov 21, 2022
| @@ -61,7 +60,7 @@ export default class MarqueeScreen extends Component<{}> { | |||
|
|
|||
| render() { | |||
| return ( | |||
| <View flex padding-page> | |||
| <ScrollView style={{flex: 1, padding: 20}}> | |||
There was a problem hiding this comment.
It is more performant to use react-native's StyleSheet instead of inline style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Marquee screen now has a scroll view.
Changelog
Marquee screen now has a scroll view.
The screen does not fit the private demo app.