Incubator.TextField - should float with defaultValue

[M-i-k-e-l]

Description

Incubator.TextField - FloatingPlaceholder should float with defaultValue
Adding shouldFloat and fixing its logic

WOAUILIB-3123

Handling edge cases, using the below PlaygroundScreen:

1. Switching between TextFields should:
   a. float\un-float if both are empty
   b. float\un-float on an empty one and remain un-floated on one with a value \ defaultValue
2. Changing defaultValue should affect the floating status
3. Deleting the defaultValue (to an empty value) should un-float

import React, {Component} from 'react';
import {View, Text, Card, Incubator, Button} from 'react-native-ui-lib';

export default class PlaygroundScreen extends Component {
  state = {
    defaultValue: 'initial value'
  };
  render() {
    return (
      <View bg-grey80 flex padding-20>
        <View marginT-20>
          <Incubator.TextField
            migrate
            marginH-s5
            placeholder={'placeholder'}
            defaultValue={this.state.defaultValue}
            floatingPlaceholder
            floatOnFocus
          />
          <Incubator.TextField migrate marginH-s5 placeholder={'placeholder'} floatingPlaceholder floatOnFocus/>
        </View>
        <Card height={100} center padding-20>
          <Text text50>Playground Screen</Text>
        </Card>
        <View flex center>
          <Button
            marginV-20
            label="Button"
            onPress={() => {
              this.setState({defaultValue: undefined});
            }}
          />
        </View>
      </View>
    );
  }
}

Changelog

Incubator.TextField - FloatingPlaceholder should float with defaultValue

[ethanshar]

There's no need to memoize primitive values (booleans, strings, etc...) 😬

[M-i-k-e-l]

Wouldn't that break the useDidUpdate dependencies? Unless I put the dependencies from here, which is a little weird.
I think we tested it once, but I can test again.

[M-i-k-e-l]

I think you're right but I found a bug :/

[Inbal-Tish]

'TextInputProps' are the OLD TextField's prop... why use them in the incubator?

[M-i-k-e-l]

No, it's RN's props

[Inbal-Tish]

Ok...

[Inbal-Tish]

Why not pass the input's 'value'? Why do we need a separate prop?

[M-i-k-e-l]

This is a prop from RN which we inherit and the user that opened the bug is using

[Inbal-Tish]

The FlotingPlaceholder only needs to know only if to float or not, why doesn't the TextField component controls it with the 'hasValue' passed in context?

[M-i-k-e-l]

You're saying that shouldFloat should be coming from somewhere else? Maybe the Presenter like in ValidationMessage?

[Inbal-Tish]

Yes. I think the floating placeholder should only get a boolean and the logic will be in the component that uses it

[M-i-k-e-l]

Done