Fix/text field flex #2345
Merged
Fix/text field flex #2345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Nov 30, 2022
| labelStyle={{alignSelf: 'center'}} | ||
| containerStyle={{alignSelf: 'center'}} | ||
| /> | ||
| <TextField label="PIN" placeholder="XXXX" centered/> |
There was a problem hiding this comment.
If you add trailingAccessory in this example and enter a long long value, the icon will exit the screen.
There was a problem hiding this comment.
I notice this and I spoke with Ethan about this before I made this PR.
Ethan told me that 'centered' is for certain cases and for short text (mainly), so the example with the trailingAccessory and long value is an 'edge case'.
If we will have an issue with that particular case in the future we will handle it.
@ethanshar
Ethan, I tagged you to confirm that.
There was a problem hiding this comment.
Yes, agree. Let's handle it when the issue rise. For now I think it's important to fix the common issue this PR fixes.
Inbal-Tish
approved these changes
Dec 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix TextFiled Incubator issues while using trailingAccessory.
TextFiled Incubator now has a new prop
centeredto center the label and the container.Issues solved:
Changelog
Fix TextFiled Incubator issues while using
trailingAccessory.