Skip to content

Fix how we render TextField children #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2022
Merged

Fix how we render TextField children #2369

merged 1 commit into from
Dec 13, 2022

Conversation

ethanshar
Copy link
Collaborator

Description

Fix how we render children in TextField component.
This should fix an issue we have in Picker (filter fieldType) that use TextField's children prop.
This replace the Input container so there's weird flex behaviors

Changelog

Fix Picker's filter fieldType layout by fixing how we render children prop in TextField

@ethanshar ethanshar added the Important for Next Release PR that must be included in the release version label Dec 12, 2022
@ethanshar ethanshar requested a review from M-i-k-e-l December 12, 2022 19:45
@M-i-k-e-l M-i-k-e-l merged commit 950cb64 into master Dec 13, 2022
@ethanshar ethanshar deleted the fix/TextField_children branch April 2, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanshar @M-i-k-e-l