NumberInput - support theme and generify useThemeProps #2370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Dec 13, 2022
| @@ -47,6 +47,7 @@ export type NumberInputProps = React.PropsWithRef< | |||
| }; | |||
|
|
|||
| function NumberInput(props: NumberInputProps, ref: any) { | |||
| const themeProps = useThemeProps(props, 'NumberInput'); | |||
There was a problem hiding this comment.
Didn't you add generics to useThemeProps so you can send it here?
There was a problem hiding this comment.
I did, but it works without it 🪄
Pretty sure that it gets the type from the input props and that's why I got the errors in Picker and Avatar
ethanshar
approved these changes
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NumberInput - support theme and generify useThemeProps
When adding
useThemePropstoNumberInputI've noticed that the props are not being used (I had a// @ts-expect-errorwhich was supposedly fixed when it should not have been), so I added generics touseThemeProps; I've fixed some errors and ignored one inasBaseComponent.Changelog