Skip to content

Incubator.TextField - centered prop should center the text itself #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2022
Merged

Incubator.TextField - centered prop should center the text itself #2375

merged 2 commits into from
Dec 21, 2022

Conversation

M-i-k-e-l
Copy link
Collaborator

Description

Incubator.TextField - centered prop should center the text itself.
This can be seen in the following example which is relevant to the private repo:

TextField label=“PIN” placeholder=“Placeholder” value={‘value’} centered style={{width: 60}}/>

Changelog

Incubator.TextField - fix centered prop not centering the text in some scenarios.

@M-i-k-e-l M-i-k-e-l requested a review from lidord-wix December 14, 2022 09:48
@lidord-wix
Copy link
Contributor

@M-i-k-e-l
Approved.. you can resolve the conflict and merge :)

@M-i-k-e-l M-i-k-e-l enabled auto-merge (squash) December 21, 2022 06:20
@M-i-k-e-l M-i-k-e-l merged commit e59bac4 into master Dec 21, 2022
@M-i-k-e-l M-i-k-e-l deleted the fix/incubator-text-field-centered-should-center-the-text branch December 21, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidord-wix lidord-wix lidord-wix approved these changes

Assignees

@lidord-wix lidord-wix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @lidord-wix