Fix/incubator dialog fader visibility and more #2379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
added
the
Important for Next Release
Inbal-Tish
reviewed
Dec 18, 2022
| @@ -163,7 +164,7 @@ const Dialog = (props: DialogProps, ref: ForwardedRef<DialogImperativeMethods>) | |||
| const renderDialog = () => { | |||
| return ( | |||
| <PanGestureHandler onGestureEvent={isEmpty(directions) ? undefined : panGestureEvent}> | |||
| <View pointerEvents={'box-none'} reanimated style={style} onLayout={onLayout} ref={setRef} testID={testID}> | |||
| <View {...containerProps} reanimated style={style} onLayout={onLayout} ref={setRef} testID={testID}> | |||
There was a problem hiding this comment.
Isn't removing pointerEvents={'box-none'} the fix? So not sure why the 'containerProps' are needed... Assuming that's for passing 'pointerEvents', in what scenario would the user need to pass pointerEvents={'box-none'} in the container props?
There was a problem hiding this comment.
In private we have a case were we render our own header which only part of it has pointerEvents: 'box-none' - that's the use case.
From the description:
Do not set pointerEvents by default (allow via props) - this fixes a bug in Android where clicking on the header closes the dialog (it goes through to the fade view)
You can look at master in private on ActionSheet (Android only) - click on the header where there's no text
Inbal-Tish
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You can look at each commit separately
Fixes for the fade view (most important is moving the
withTimingto theuseAnimatedStyle), the others are making the code a little better.Do not set pointerEvents by default (allow via props) - this fixes a bug in Android where clicking on the header closes the dialog (it goes through to the fade view)
WOAUILIB-3268
Changelog
Fix Incubator.Dialog's fader view not being shown sometimes