Image - pass width and height to image style

[Inbal-Tish]

Description

When passing 'width' and 'height' the image doesn't render (only when they are passed in style).
Image - pass width and height to image style.

Changelog

⚠️ Image - pass 'width' and 'height' to image style to fix layout props not applied to Image without 'style'.

[M-i-k-e-l]

The example below seems to be working fine on master

<Image
  source={{uri: 'https://static.wixstatic.com/media/d911269bdf7972c9a59ba30440cb3789.jpg_128'}}
  width={50}
  height={50}
/>

Can you please provide an example that fails?

[Inbal-Tish]

The example below seems to be working fine on master

<Image
  source={{uri: 'https://static.wixstatic.com/media/d911269bdf7972c9a59ba30440cb3789.jpg_128'}}
  width={50}
  height={50}
/>

Can you please provide an example that fails?

This example doesn't work on master...

[M-i-k-e-l]

Please add the relevant example and a ⚠️

[M-i-k-e-l]

I don't think the cover is needed here, if the user makes a mistake they can fix it (this will be bugged without an overlay as well)

[M-i-k-e-l]

Also, personally I prefer to remove the extra const sizeProps.
Maybe just {width, height} or (width || height) && {width, height}?

[Inbal-Tish]

What do you mean by 'this will be bugged without an overlay as well'? This solution works whether you pass overlay or not...

[M-i-k-e-l]

I think I meant that if the user adds width and forgets height (or vice versa, or adds a width with cover etc) they will have bugs that they will need to fix.

[Inbal-Tish]

Yes, that's for sure

[M-i-k-e-l]

Was this on purpose?

[Inbal-Tish]

Yes, I remove the 'style' prop

[M-i-k-e-l]

Added a small comment, approved