Fix/ add webStyle to TextField #2387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Dec 21, 2022
| @@ -69,6 +68,10 @@ const styles = StyleSheet.create({ | |||
| textAlignVertical: 'center' | |||
| } | |||
| }) | |||
| }, | |||
| webStyle: { | |||
There was a problem hiding this comment.
Does this solve your issue? I believe we meant to get the 'webStyle' to a const outside of the stylesheet, as the stylesheet is typed. You can move it outside the component or create a memorized const as this is not a dynamic style
There was a problem hiding this comment.
Yes it solves the issue (with the ts-expect-error) and keeps the style in the stylesheet so I think it is more readable and clean.
Inbal-Tish
approved these changes
Jan 1, 2023
|
@lidord-wix Approved. Please fix build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TextField - fix web style
Changelog
TextField - fix web style