Skip to content

Fix dummyPlaceholder style #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2023
Merged

Fix dummyPlaceholder style #2390

merged 2 commits into from
Jan 5, 2023

Conversation

M-i-k-e-l
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l commented Dec 26, 2022 •
edited
Loading

Description

After looking at MainInput size issue we've discussed, I think the dummy placeholder should have the inputStyle for the typography.
Technically it can be [typographyStyle, others.style, styles.dummyPlaceholder] but I think that will be less clear.

Changelog

TextField - fix dummyPlaceholder style

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar December 26, 2022 07:24
@ethanshar
Copy link
Collaborator

@M-i-k-e-l Approved.
Need to fix conflicts

@M-i-k-e-l M-i-k-e-l enabled auto-merge (squash) January 5, 2023 09:59
@M-i-k-e-l M-i-k-e-l merged commit f8cb676 into master Jan 5, 2023
@M-i-k-e-l M-i-k-e-l deleted the fix/incubator-text-field-dummy-placeholder branch January 5, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @ethanshar