Fix flex issue of TextField when rendered #2391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
added
Important for Next Release
M-i-k-e-l
approved these changes
Dec 27, 2022
ethanshar
added a commit
that referenced
this pull request
Dec 27, 2022
* Fix flex issue of TextField when rendered * Fix NumberInput with TextField's new flexness Co-authored-by: M-i-k-e-l <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix flex issue of TextField when rendered by passing flexG to the input container.
I added a note there that this will bring back a known issue with trailing accessory being pushed, but the flex issue is worse.
Fix #2389 2389
Changelog
Fix flex issues with TextField when rendered in a row container