Incubator.Dialog - use new Gesture API + refactor #2409
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incubator.Dialog - use new Gesture.Pan API and refactor to a "single" SharedValue.
You should probably look at the file as a whole and not the changes.
As discussed there are a few improvements here:
Gesture.Pan
fromreact-native-gesture-handler
.SharedValue
for animations (still needed an extra one for theinitialTranslation
).HiddenLocation - consider changing from useState to useSharedValue
Notes:
modalVisibility
state in order to handle the user changingvisible
tofalse
(for example pressing aButton
\ListItem
that closes theDialog
.withTiming
and with the default duration, we can change it later.onLayout
is called even when the view is hidden (not sure if this is the new API or if I was wrong before), but it should make the opacity flicker a non-issue.Changelog
Incubator.Dialog - use new Gesture API + refactor