Skip to content

Fixed this.setState error for android api under 17 #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Fixed this.setState error for android api under 17 #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e33e653
Fixed this.setState error for android api under 17
skuzoluk Sep 23, 2018
b06fb4c
Fix for android platform <=17
skuzoluk Sep 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/button/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ export default class Button extends BaseComponent {
if (!_.isUndefined(props.containerStyle)) {
console.error('Button "containerStyle" prop will be deprecated soon, please use "style" instead');
}
this.getComponentDimensions = this.getComponentDimensions.bind(this);
}

// This method will be called more than once in case of layout change!
Expand Down
1 change: 1 addition & 0 deletions typings/components/button/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export default class Button extends BaseComponent {
if (!_.isUndefined(props.containerStyle)) {
console.error('Button "containerStyle" prop will be deprecated soon, please use "style" instead');
}
this.getComponentDimensions = this.getComponentDimensions.bind(this);
}
// This method will be called more than once in case of layout change!
getComponentDimensions(event) {
Expand Down