Skip to content

fix: web load svg tag data #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 16, 2023
Merged

fix: web load svg tag data #2410

merged 18 commits into from
Jan 16, 2023

Conversation

OrenZak
Copy link
Contributor

@OrenZak OrenZak commented Jan 8, 2023

Description

Fix loading svg data tag on web

Changelog

  • refactor svgImage/index.web.ts to allow render a svg tag data
  • added demo button with svg data tag as icon source

@@ -28,7 +28,7 @@
"react-native-shimmer-placeholder": "^2.0.8",
"react-native-svg": "^12.1.0",
"react-native-svg-transformer": "^0.14.3",
"react-native-ui-lib": "snapshot",
"react-native-ui-lib": "6.27.3-snapshot.2347",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example does work.
We need to change the version to master or ga.

@adids1221 adids1221 merged commit bd2df6a into master Jan 16, 2023
@OrenZak OrenZak deleted the fix/web_load_svg_tag branch January 16, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants