fix: TextField validateOnChange with defaultValue executed on start #2411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
reviewed
Jan 10, 2023
package.json
Outdated
| @@ -33,7 +33,8 @@ | |||
| "docs:build": "node scripts/buildDocs.js", | |||
| "snippets:build": "node scripts/generateSnippets.js", | |||
| "demo": "./scripts/demo.sh", | |||
| "release": "node ./scripts/release.js" | |||
| "release": "node ./scripts/release.js", | |||
| "start:web": "npm --prefix webDemo run start" | |||
There was a problem hiding this comment.
Can you please move it to be after the start script? just to keep it in a logical order :)
| @@ -42,7 +42,7 @@ export default function useFieldState({ | |||
| if (props.value !== value) { | |||
| setValue(props.value); | |||
|
|
|||
| if (validateOnChange) { | |||
| if (validateOnChange && (!Constants.isWeb || value !== props.defaultValue)) { | |||
There was a problem hiding this comment.
From what I've seen, it also reproduces on mobile
Please verify it and if it's true, add this condition constantly :)
There was a problem hiding this comment.
yep! you are right :)
i just pushed a fix for your comments.
AmitShwarts
changed the title
uncle-bot
approved these changes
Jan 10, 2023
lidord-wix
approved these changes
Jan 10, 2023
AmitShwarts
deleted the
amitshw/fix-web-text-field-valdidate-on-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug: validatingOnChange executed on start when providing defaultValue
Changelog
Fix: validatingOnChange executed on start when providing defaultValue