Skip to content

fix: touchable opacity ignores event on press #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

AmitShwarts
Copy link
Contributor

Description

When pressing on TouchableOpacity it ignores the event and pass only the props.

Changelog

Fix: Don't ignore the event passed to TouchableOpacity onPress

Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks harmless.. but can I ask why you need the event itself?
Do you have an example?

@AmitShwarts
Copy link
Contributor Author

Looks harmless.. but can I ask why you need the event itself? Do you have an example?

Yes, the Viewer expects to get the nativeEvent and then connect some logic from Velo handlers.
without the nativeEvent the press event can't processed as expected.

@lidord-wix lidord-wix merged commit 9aed4d7 into master Jan 15, 2023
@AmitShwarts AmitShwarts deleted the fix/thouchable-opacity-onpress branch January 15, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants