Incubator.Dialog - allow headless testing mocking #2443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
approved these changes
Feb 1, 2023
jest-setup.js
Outdated
| @@ -1,4 +1,5 @@ | |||
| import {NativeModules, AccessibilityInfo} from 'react-native'; | |||
| global.__UI_LIB_TESTING__ = true; | |||
There was a problem hiding this comment.
Can we have less underscores 😬
I think global.UILIB_TESTING or global._UILIB_TESTING is enough
M-i-k-e-l
deleted the
tests/incubator-dialog-support-headless-tests-v3
branch
M-i-k-e-l
added a commit
that referenced
this pull request
Feb 5, 2023
* Incubator.Dialog - allow headless testing mocking * Rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All changed in this PR are required for this to work except this one:
Added
typings/global.d.tsto solve a TS error (it is not exported); we can add an ignore if you prefer.Changelog
Incubator.Dialog - support headless tests