Skip to content

ColorPicker style prop deprecation #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 9, 2023
Merged

ColorPicker style prop deprecation #2444

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b99eb86
ColorPicker style prop deprecation
adids1221 Feb 1, 2023
785d0c5
Fixed review notes
adids1221 Feb 2, 2023
8b10da7
background prop added to the api.json file
adids1221 Feb 2, 2023
0b490d8
Merge branch 'master' into infra/ColorPicker_style_deprecation
adids1221 Feb 6, 2023
69bb6f3
Changed the 'backgroundColor' prop description
adids1221 Feb 6, 2023
c5092b5
background prop added to the ColorPalette api json file, Fixed backgr…
adids1221 Feb 8, 2023
d7ca898
Merge branch 'master' into infra/ColorPicker_style_deprecation
adids1221 Feb 8, 2023
62ff61c
Fixed review notes, refactor comments
adids1221 Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/colorPicker/colorPicker.api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"description": "Accessibility labels as an object of strings",
"default": "{\n addButton: 'add custom color using hex code',\n dismissButton: 'dismiss',\n doneButton: 'done',\n input: 'custom hex color code'\n}"
},
{"name": "style", "type": "ViewStyle", "description": "Component's style"},
{"name": "testID", "type": "string", "description": "The test id for e2e tests"}
],
"snippet": [
Expand Down
17 changes: 13 additions & 4 deletions src/components/colorPicker/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import Button from '../button';
import ColorPalette from '../colorPalette';
import {SWATCH_MARGIN, SWATCH_SIZE} from '../colorSwatch';
import ColorPickerDialog, {ColorPickerDialogProps} from './ColorPickerDialog';
import {LogService} from '../../services';

interface Props extends ColorPickerDialogProps {
/**
Expand Down Expand Up @@ -65,15 +66,23 @@ const ACCESSIBILITY_LABELS = {
class ColorPicker extends PureComponent<Props> {
static displayName = 'ColorPicker';

static defaultProps = {
accessibilityLabels: ACCESSIBILITY_LABELS,
backgroundColor: Colors.$backgroundDefault
};
constructor(props: Props) {
super(props);

if (props.style) {
LogService.warn('UILib ColorPicker style prop is deprecated.');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LogService.warn('UILib ColorPicker style prop is deprecated.');
LogService.warn('UILib ColorPicker style prop is deprecated. Please stop using it.');

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also tell the user what to do, otherwise, they will ask if there is another prop that replaces it etc.

}
}

state = {
show: false
};

static defaultProps = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We keep the statics up after the static displayName

accessibilityLabels: ACCESSIBILITY_LABELS,
backgroundColor: Colors.$backgroundDefault
};

get animatedIndex() {
const {animatedIndex, colors} = this.props;
if (animatedIndex === undefined) {
Expand Down