-
Notifications
You must be signed in to change notification settings - Fork 734
Dialog and Modal fix for web #2450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
28ebf0a
Dialog and Modal fix for web
adids1221 8af3a08
Button, Icon, picker - usePickerLabel cahnges according to web using
adids1221 7da78b7
Merge branch 'master' into fix/Picker_web_dialog
adids1221 542a303
Fixed the selected indicator color
adids1221 7ef136f
picker icon color change on selected item
adids1221 5a62d37
Fixed eslint error
adids1221 6a12cbc
Fixed svgimage component web file
adids1221 18db757
checkbox fix, icon changed default size for web
adids1221 a22f365
Merge branch 'master' into fix/Picker_web_dialog
adids1221 9cbb7e4
Removed unnecessary logs, files unnecessary changes
adids1221 43e545b
SvgImage web default size changed back to 16
adids1221 c45054a
Checkbox - cheanged Animated.Image to AnimatedIcon, Icon now wrraped …
adids1221 825e697
Merge branch 'master' into fix/Picker_web_dialog
adids1221 0e2f1f9
Fixed type issues in Chips index
adids1221 9b3927e
Checkbox removed forward ref from prop types
adids1221 b38fd1b
added ref to Image in Icon
adids1221 c66976e
Fixed tintColor in AnimatedIcon
adids1221 3ae70d3
Chip index - removed reformat from th ePR
adids1221 4a08e9c
checkbox props changed back, icon size logic reformat, usePickerLabel…
adids1221 7000ef2
Merge branch 'master' into fix/Picker_web_dialog
adids1221 53f50d9
fixed review notes
adids1221 215862d
Fixed size issue in icon
adids1221 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we're not using Icon all of the time? both for web and mobile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if we will user Icon and the user don't pass any
tintColor
the Icon will get the default color.So if we change it to Icon it will break some users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we need to migrate to Icon IMO, we can do it v8.
Can you add it to the v8 spreadsheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done added to the spreadsheet.