Skip to content

Incubator.TextField - add readonly state #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2023
Merged

Incubator.TextField - add readonly state #2455

merged 2 commits into from
Feb 13, 2023

Conversation

M-i-k-e-l
Copy link
Collaborator

Description

Incubator.TextField - add readonly state
Main PR for WOAUILIB-3345

Changelog

Incubator.TextField - add readonly state

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar February 9, 2023 10:56
ethanshar
ethanshar approved these changes Feb 12, 2023
View reviewed changes
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Approved. Just add the new prop to the api.json file

src/incubator/TextField/types.ts
/**
* A UI preset for read only state
*/
readonly?: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't add the new prop to the api.json

@M-i-k-e-l M-i-k-e-l enabled auto-merge (squash) February 13, 2023 09:55
@M-i-k-e-l M-i-k-e-l merged commit 1493474 into master Feb 13, 2023
@M-i-k-e-l M-i-k-e-l deleted the feat/incubator-text-field-add-readonly-state branch February 13, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @ethanshar