Skip to content

Incubator.TextField - handle long validationMessage with char count #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2023
Merged

Incubator.TextField - handle long validationMessage with char count #2460

merged 1 commit into from
Feb 12, 2023

Conversation

M-i-k-e-l
Copy link
Collaborator

Description

Incubator.TextField - handle long validationMessage with char count
Use the following example to reproduce:

<TextField
  placeholder={'bla'}
  migrate
  showCharCounter
  maxLength={100}
  validateOnStart
  validate={['required']}
  validationMessage={['Really long validation message with character counter nearby it']}
/>

WOAUILIB-3387

Changelog

Incubator.TextField - handle long validationMessage with char count

@M-i-k-e-l M-i-k-e-l requested a review from lidord-wix February 12, 2023 06:46
lidord-wix
lidord-wix approved these changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, feel free to merge once the build passes (looks like a flaky issue we had before, try to rerun)

@M-i-k-e-l M-i-k-e-l merged commit 9c8727a into master Feb 12, 2023
@M-i-k-e-l M-i-k-e-l deleted the fix/incubator-text-field-long-validation-message branch February 12, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidord-wix lidord-wix lidord-wix approved these changes

Assignees

@lidord-wix lidord-wix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @lidord-wix