refactor TouchableOpacity forwarding event on onPress and onLongPress #2462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
reviewed
Feb 12, 2023
| @@ -155,12 +159,12 @@ class TouchableOpacity extends PureComponent<Props, {active: boolean}> { | |||
| ); | |||
| } | |||
|
|
|||
| onPress(event: BaseSyntheticEvent) { | |||
| this.props.onPress?.({...this.props, ...event}); | |||
| onPress(event: GestureResponderEvent) { | |||
There was a problem hiding this comment.
Why you changed it from BaseSyntheticEvent to GestureResponderEvent?
There was a problem hiding this comment.
this is the correct typing in React Native:
onLongPress?: ((event: GestureResponderEvent) => void) | undefined;
/**
* Called when the touch is released,
* but not if cancelled (e.g. by a scroll that steals the responder lock).
*/
onPress?: ((event: GestureResponderEvent) => void) | undefined;
onPressIn?: ((event: GestureResponderEvent) => void) | undefined;
onPressOut?: ((event: GestureResponderEvent) => void) | undefined;
There was a problem hiding this comment.
OK, please just verify it's the same type for web events (you can run the web demo with this change).
I thought you picked the BaseSyntheticEvent last time for that reason
lidord-wix
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change the way we forward the event to onPress and onLongPress handler to send event along with props, instead spreading the event together with props
Changelog
refactor TouchableOpacity forwarding event on onPress and onLongPress