Skip to content

RN71 upgrade #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 10, 2023
Merged

RN71 upgrade #2504

merged 20 commits into from
Mar 10, 2023

Conversation

Inbal-Tish
Copy link
Collaborator

Description

RN71 upgrade

Changelog

RN71 upgrade

@Inbal-Tish Inbal-Tish marked this pull request as draft February 27, 2023 10:32
@Inbal-Tish Inbal-Tish requested a review from ethanshar March 6, 2023 12:45
@Inbal-Tish
Copy link
Collaborator Author

@ethanshar I disabled the Incubator.Dialog test for now. I'll keep looking for a solution for it but I don't think it should block this upgrade

@Inbal-Tish Inbal-Tish marked this pull request as ready for review March 6, 2023 13:01
ethanshar
ethanshar reviewed Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Wrote some comments.

I do have an issue on IOS (Android is fine) in the main screen when scrolling down the list of screens it throws an error, something related to the sections list.
Do you get it?

@ethanshar
Copy link
Collaborator

@Inbal-Tish One more thing.
It's worth someone with the new Mac to checkout this PR and see the new version works fine. either @M-i-k-e-l or @adimorwix can check it, they have the new mac

@Inbal-Tish
Copy link
Collaborator Author

Looks good. Wrote some comments.

I do have an issue on IOS (Android is fine) in the main screen when scrolling down the list of screens it throws an error, something related to the sections list. Do you get it?

Fixed!

@Inbal-Tish
Copy link
Collaborator Author

@Inbal-Tish One more thing. It's worth someone with the new Mac to checkout this PR and see the new version works fine. either @M-i-k-e-l or @adimorwix can check it, they have the new mac

Ok. I'll ask them to check it.

@Inbal-Tish Inbal-Tish requested a review from ethanshar March 9, 2023 08:07
@Inbal-Tish
Copy link
Collaborator Author

@Inbal-Tish One more thing. It's worth someone with the new Mac to checkout this PR and see the new version works fine. either @M-i-k-e-l or @adimorwix can check it, they have the new mac

Ok. I'll ask them to check it.

Miki says it looks ok on both Android and iOS

@M-i-k-e-l
Copy link
Collaborator

M-i-k-e-l commented Mar 9, 2023 •
edited
Loading

@ethanshar @Inbal-Tish
Both platforms installed and small sanity was performed

@ethanshar ethanshar merged commit 0edc861 into master Mar 10, 2023
@Inbal-Tish Inbal-Tish deleted the infra/RN71_upgrade branch June 13, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Inbal-Tish @ethanshar @M-i-k-e-l